Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add linking tests #142

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

test: add linking tests #142

wants to merge 8 commits into from

Conversation

bashbunni
Copy link
Member

@bashbunni bashbunni commented May 6, 2022 •
edited

Changes

  • add tests for linking two clients on a charm server

Related Issues

#132

@bashbunni bashbunni added the enhancement New feature or request label May 6, 2022
@bashbunni bashbunni requested a review from toby May 24, 2022 20:12
@bashbunni bashbunni linked an issue May 24, 2022 that may be closed by this pull request
test: add linking tests #132
Open
@bashbunni
Copy link
Member Author

bashbunni commented Jun 15, 2022 •
edited

Changes:

  • use the client returned from testserver.SetupTestServer(t) instead of throwing it out and creating a new one
    example

  • try to test rejecting a link attempt to make sure that works too

@bashbunni bashbunni self-assigned this Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toby toby Awaiting requested review from toby

Assignees

@bashbunni bashbunni

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test: add linking tests
2 participants
@bashbunni @aymanbagabas