Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added methods to allow updating Body of stashed documents #13

Closed
wants to merge 1 commit into from

Conversation

shitchell
Copy link

Adds a method to allow updating a stashed document's Body and a method to update the Body and Note simultaneously.

Addresses charmbracelet/glow#214

@coveralls
Copy link

Pull Request Test Coverage Report for Build 397952210

  • 0 of 31 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 7.123%

Changes Missing Coverage Covered Lines Changed/Added Lines %
glow.go 0 31 0.0%
Totals Coverage Status
Change from base Build 368940477: -0.2%
Covered Lines: 76
Relevant Lines: 1067

💛 - Coveralls

@shitchell shitchell changed the title Added SetMarkdownContent() and SetMarkdownBody() to allow editing sta… Added methods to allow updating Body of stashed documents Dec 3, 2020
@shitchell
Copy link
Author

shitchell commented Dec 10, 2020

Just commenting to hopefully bring some attention to this. Without these methods in the charm library, it's incredibly more complicated to update the body for a stashed document after editing it (charmbracelet/glow#182). With these methods, it's basically just one line.

@meowgorithm
Copy link
Member

Appreciate that, @shitchell. We're a little busy internally at the moment but this definitely on our to-do list.

@toby
Copy link
Contributor

toby commented Dec 15, 2021

The stash methods have been moved to https://github.com/charmbracelet/glow.

@toby toby closed this Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants