feat: add support for Cmd wrapping (for routing) #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is one possible solution for allowing components to wrap any `tea.Cmd` that comes from a sub-component's `Update()`. See the comment in the code for other possible options.
|
Would this also be helpful to reduce the custom ID handling in https://github.com/charmbracelet/bubbles/blob/master/spinner/spinner.go ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one possible solution for allowing components to wrap any
tea.Cmdthat comes from a sub-component'sUpdate(). See the comment in the code for other possible options.Fixes #751
I'm creating this as a draft PR because this seemed like the easiest way to share one possible solution to the "how can a component reliably route a message to the correct subcomponent?" question. There are pros/cons to any of the solutions; this just provides a starting point for the discussion.