Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gracefully quit panicking Cmd #846

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

joerdav
Copy link

@joerdav joerdav commented Oct 18, 2023

Fixes: #234

@muesli
Copy link
Member

muesli commented Oct 18, 2023

We should try and add a test for this.

@joerdav
Copy link
Author

joerdav commented Oct 18, 2023

Thanks, good point! I've added some panic recovery tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recover panics from within cmds goroutines
2 participants