Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): improved model initialization consistancy #772

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

samyosm
Copy link

@samyosm samyosm commented Jul 6, 2023

I have made sure to maintain consistency across all examples by aligning them with the documentation, which uses an initialModel method for model initialization.

@samyosm samyosm changed the title chore(examples): impoved model initialization consistancy chore(examples): improved model initialization consistancy Jul 6, 2023
@muesli
Copy link
Member

muesli commented Mar 1, 2024

While I prefer the naming consistency (newModel -> initialModel), we should probably simplify the code as much as possible and get rid of the method in some examples. We're also planning to streamline the bubbles a bit and make them proper tea.Models.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants