Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use Termenv.Output to write to tty #455

Merged
merged 1 commit into from Sep 27, 2022
Merged

feat: use Termenv.Output to write to tty #455

merged 1 commit into from Sep 27, 2022

Conversation

muesli
Copy link
Member

@muesli muesli commented Sep 22, 2022 •
edited

  • Uses a termenv.Output to manage writing to outputs
  • Enables us to use arbitrary output devices with color detection
  • Prevents concurrent output access from lipgloss (depending on its next branch, to be merged)
  • Removes code duplication (ANSI screen handling, Windows console) with termenv

Fixes #420, #172, #206, #302.

@muesli muesli force-pushed the termenv-output branch 2 times, most recently from 00bec7a to c9b0176 Compare September 22, 2022 09:06
@meowgorithm meowgorithm self-requested a review September 27, 2022 00:15
@muesli muesli merged commit 6c449e5 into master Sep 27, 2022
@muesli muesli deleted the termenv-output branch September 27, 2022 00:49
@muesli muesli mentioned this pull request Sep 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meowgorithm meowgorithm Awaiting requested review from meowgorithm meowgorithm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tea and termenv do not honor WithOutput properly
2 participants
@muesli @meowgorithm