Allow users to supply a custom cancelReader #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables callers to supply their own form of TTY cancellation. We have our own Windows TTY library based on ConPTY, and would like to use it with bubbletea, but it's not possible unless we can provide our own form of read cancellation.
|
So once we merge #222 we should update this PR to get it where it needs to be in order to merge. Off the cuff, I imagine this would be best implemented as a |
xsadegh
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables callers to supply their own form of TTY cancellation.
We have our own Windows TTY library based on ConPTY, and would like
to use it with bubbletea, but it's not possible unless we can provide
our own form of read cancellation.
I'm not certain this is the best approach by any means, so suggestions are welcome!