Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow passing a custom panic handler #218

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: allow passing a custom panic handler #218

wants to merge 1 commit into from

Conversation

aymanbagabas
Copy link
Member

@aymanbagabas aymanbagabas commented Feb 3, 2022 •
edited

Use WithPanicHandler() to pass a function that gets executed on panics

@meowgorithm
Copy link
Member

meowgorithm commented Feb 4, 2022 •
edited

If you don’t mind, let’s pull WithPanicHandler from the PR (unless it’s needed right now for Soft Serve). Otherwise, would prefer to consider it a bit more before we expose it. Everything else looks good, but please do test this a bit and let’s hold off on putting it into a release.

@meowgorithm meowgorithm changed the title feat: add panic handler and kill the program from the outside feat: kill the program and restore terminal state Feb 4, 2022
@aymanbagabas
feat: allow passing a custom panic handler
9cd5d48 
Use `WithPanicHandler()` to pass a function that gets executed on panics
@aymanbagabas aymanbagabas changed the title feat: kill the program and restore terminal state feat: allow passing a custom panic handler Feb 4, 2022
@aymanbagabas
Copy link
Member Author

If you don’t mind, let’s pull WithPanicHandler from the PR (unless it’s needed right now for Soft Serve). Otherwise, would prefer to consider it a bit more before we expose it. Everything else looks good, but please do test this a bit and let’s hold off on putting it into a release.

Sounds good to me! Kill() is now in a separate PR #219

@bashbunni bashbunni added the enhancement New feature or request label Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meowgorithm meowgorithm Awaiting requested review from meowgorithm meowgorithm is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aymanbagabas @meowgorithm @bashbunni