Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bubbletea does not render special characters properly #907

Closed
louisescher opened this issue Jan 21, 2024 · 6 comments
Closed

bubbletea does not render special characters properly #907

louisescher opened this issue Jan 21, 2024 · 6 comments

Comments

@louisescher
Copy link

Describe the bug
When using, for example, German "Umlaute" (ä, ü, ö), bubbletea does not render the characters at all. Another German-specific character, ß, renders as á instead. This does not seem to be a problem with the font, as I can use the letters when writing out commands.

Setup
Please complete the following information along with version numbers, if applicable.

  • OS: Windows
  • Shell: Windows Terminal/cmd

To Reproduce
Steps to reproduce the behavior:

  1. Create a bubbletea application with a textinput
  2. Try to type any of the letters into the textinput
  3. See the characters not being typed/rendered

Source Code
The textinput code example can be used to replicate this behaviour.

Expected behavior
The special characters should render, however, they do not.

Screenshots
Here is an example of what happens when typing in the ß character:
image
To confirm, here you can see how my terminal renders the characters with the same font & settings:
image

@meowgorithm
Copy link
Member

meowgorithm commented Jan 22, 2024

Okay cool, this seems to be an issue on Windows in particular (and possibly a regression).

There’s a duplicate issue at charmbracelet/bubbles#460, however I think this repo is the appropriate place for this.

@meowgorithm
Copy link
Member

Alright, so I'm able to reproduce this on Windows and it's indeed it's specific to Bubble Tea. We'll investigate accordingly. International support is important to us.

@meowgorithm
Copy link
Member

Okey-dokey, this is now fixed on master via #878 and will be available in the next release. Cheers!

@louisescher
Copy link
Author

Amazing, thanks for all the hard work. Should I close this now or wait for the release to come out?

@meowgorithm
Copy link
Member

All the credit here belongs to @aymanbagabas and @erikgeiser 🙂

If you don't mind let's close this out.

@louisescher
Copy link
Author

Much love to you two then! Thanks again, marking this as closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants