Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended Latin characters not supported in textinput on Windows #460

Closed
StephGD opened this issue Jan 20, 2024 · 11 comments
Closed

Extended Latin characters not supported in textinput on Windows #460

StephGD opened this issue Jan 20, 2024 · 11 comments

Comments

@StephGD
Copy link

StephGD commented Jan 20, 2024

Hello,
First of all, thanks for this amazing libraries.
In the textinput and the textarea bubble, the latin accentuated characters (ex. éàêâö) aren't supported. This keys are bypassed. It's a little bit annoying if you working with some language (like french :-). This issue (or non-feature) is also in "gum" and "huh".
Is there a solution for working with this characters ?
Thanks for your time, have a good day (or night :-)

@meowgorithm
Copy link
Member

meowgorithm commented Jan 20, 2024

Hi there! This shouldn't be the case; we have tested this library with diacritics and extended Latin fairly extensively.

What terminal emulator, operating system, and window manager are you using?

@StephGD
Copy link
Author

StephGD commented Jan 20, 2024

I tried some possibilities. I'm on windows 10. This won't work correctly on the official terminal emulator with powershell config and cmd config. Same with VS Code's terminal, Wezterm, the powershell original console (without emulator) and the cmd console.
Buuuut... (drum roll) ...it work perfectly fine on debian with the linux subsystem.
All the output works, but I have the same issue with all the input (also with the filter in the list).

@meowgorithm meowgorithm changed the title Latin characters not supported in textinput Extended Latin characters not supported in textinput on Windows Jan 21, 2024
@meowgorithm
Copy link
Member

Okay, so perhaps it's a Windows issue. The majority of our testing on Windows has been around IME (Chinese, Japanese, Korean) whereas we've spent more time with Latin diacritics on Linux and macOS.

While unlikely, this could also be related to physical keyboards sending diacritics on Windows. Am I correct to assume you're using a proper AZERTY keyboard to enter characters like é, è, and à?

Additionally, what gets inputted when you send a ç?

Finally, what's your locale (i.e. fr_FR.UTF-8)?

@StephGD
Copy link
Author

StephGD commented Jan 21, 2024

It's exact, I use a AZERTY keyboard and the layout is fr_FR.
When I try with the "ç" (and the "ù"), nothing's happening. With the euro symbol (altGr+e) it's different, it replaced by the "?".
Finally I tried to pass à diacritic as KeyMsg. Same result, nothing's happening when I press the specified key.
I don't know if it helps, but the other characters on the same keys (accessible with Shift and altGr) works fine.

@meowgorithm
Copy link
Member

Hi! We have another report of this over at charmbracelet/bubbletea#907 which is probably a better place for this issue. I'm going to close this one; let’s continue the conversation there.

@StephGD
Copy link
Author

StephGD commented Jan 22, 2024

Hi! This is indeed a better place.

@meowgorithm
Copy link
Member

Good news! @aymanbagabas’s mystical PR charmbracelet/bubbletea#878 will fix this issue. We'll update here when we merge.

@StephGD
Copy link
Author

StephGD commented Jan 22, 2024

Amazing ! Thanks for your efforts.

@meowgorithm
Copy link
Member

This is now fixed in Bubble Tea on master and will be available in the next Bubble Tea release.

@StephGD
Copy link
Author

StephGD commented Feb 27, 2024

Hi! Thanks a lot for this enhancement and for your work.

@StephGD
Copy link
Author

StephGD commented Mar 2, 2024

I finally tried with the master branch and it works perfectly under Windows (cmd, Powershell, Wezterm and Windows terminal emulator). I also saw that now the resize signal also works "out of the box" in Windows. Thank you again for this improvement and for all your works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants