fix: lock mutex before checking altscreen state

This prevents the odd race condition where Enter- & ExitAltScreen are called concurrently.
charmbracelet · Oct 13, 2022 · db66482 · db66482
1 parent b8ef6f8
commit db66482
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/standard_renderer.go b/standard_renderer.go
@@ -268,13 +268,13 @@ func (r *standardRenderer) altScreen() bool {
 }
 
 func (r *standardRenderer) enterAltScreen() {
+	r.mtx.Lock()
+	defer r.mtx.Unlock()
+
 	if r.altScreenActive {
 		return
 	}
 
-	r.mtx.Lock()
-	defer r.mtx.Unlock()
-
 	r.altScreenActive = true
 	r.out.AltScreen()
 
@@ -291,13 +291,13 @@ func (r *standardRenderer) enterAltScreen() {
 }
 
 func (r *standardRenderer) exitAltScreen() {
+	r.mtx.Lock()
+	defer r.mtx.Unlock()
+
 	if !r.altScreenActive {
 		return
 	}
 
-	r.mtx.Lock()
-	defer r.mtx.Unlock()
-
 	r.altScreenActive = false
 	r.out.ExitAltScreen()