fix: default textarea EndOfBufferCharacter should be ' ' #510
+147
−147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfulz
pushed a commit
to mfulz/bubbles
that referenced
this pull request
Apr 25, 2024
|
I agree with you (obviously) that this should be the default. Be aware that there was a desire to emulate the look of Vim (something I learned later from my discussions with @maaslalani). |
mikelorant
approved these changes
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the default
EndOfBufferCharacterto a space character. I tend to agree with the conclusion in #491 that this is probably a better default.Happy to discuss if this isn't the direction you want to go @maaslalani.