Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow to mark colums as hidden. This might be helpful to hide s… #412

Closed

Conversation

deicon
Copy link

@deicon deicon commented Aug 25, 2023

Tables might contain more than needs to be visible to the user.
Consider a table like

ID PrimaryKey UserName
1 12392839281. My_Username

Once displayed to the user, we want the user to select a row but don't want to expose the PrimaryKey. This is only used after
user selection for further processing.

This can then be used to enable charmbracelet/gum#320

@deicon
Copy link
Author

deicon commented Oct 17, 2023

@maaslalani any chance this gets a review any time soon ?

@maaslalani
Copy link
Member

@maaslalani any chance this gets a review any time soon ?

Hey @deicon, because of the new Lip Gloss tables (https://github.com/charmbracelet/lipgloss/releases/tag/v0.9.0) we're currently integrating that renderer into Bubbles which will then be used in Gum. So we should review / revisit this feature after the new table renderer is introduced in Bubbles and Gum.

@maaslalani
Copy link
Member

Hey @deicon, we recently introduced hiding a column by setting the width to 0:

Let us know if this solves your use case, feel free to re-open this PR or create a new issue if it doesn't!

@maaslalani maaslalani closed this Feb 28, 2024
@deicon
Copy link
Author

deicon commented Feb 28, 2024

@maaslalani Kind of. Mostly I was trying to fix charmbracelet/gum#320
by a PR in GUM. to make this even better, I would love to hide some columns but still use values of columns as return values from the gum table command. charmbracelet/gum#415

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants