Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl+Left/Right for WordForward/Backward #387

Merged
merged 1 commit into from Mar 4, 2024
Merged

Conversation

maaslalani
Copy link
Member

This PR enables ctrl+left for WordBackward and ctrl+right
for WordForward.

NB: theoretically this should work but I didn't see this work in Kitty, iTerm,
or terminal.app.

@maaslalani
Copy link
Member Author

Fixes #150

@meowgorithm
Copy link
Member

If this doesn’t work in more or less all terminals (including urxvt) we shouldn’t support the binding.

@franalbani
Copy link

franalbani commented Jun 17, 2023

I'm totally new to Go. This is what I did (with ChatGPT help):

I tried with:

  • allacritty ✔️
  • kitty ✔️
  • cool-retro-term ✔️
  • Linux VT (CTRL+ALT+F2) ❎

Please correct the steps if there is a simpler way.

@bashbunni bashbunni linked an issue Jun 17, 2023 that may be closed by this pull request
@lietu
Copy link

lietu commented Mar 3, 2024

How about supporting the very commonplace binding for those environments where it is sufficiently trivial to do so, and add a new issue about supporting it on the more rare ones that it's still not working in?

@meowgorithm
Copy link
Member

I'm able to verify these bindings; it's fine to merge this.

On macOS they're unavailable by default because they're bound to Mission Control (see screenshot); when unbound the keystrokes are captured by the terminal. The bindings also exist in Bubble Tea, which means they've been vetted.

image

@maaslalani maaslalani merged commit 8a6f531 into master Mar 4, 2024
18 checks passed
@maaslalani maaslalani deleted the textinput-ctrl-arrows branch March 4, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat(textinput): ctrl + left/right bindings for word jumping
4 participants