fix: table.SetCursor cursor rendered offscreen #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using table.SetCursor to modify the location of the cursor in a table, the viewport wasn't getting updated in the same way as MoveUp/MoveDown which was causing the resulting View() to sometimes not include the cursor. This changeset fixes this by internally converting any SetCursor calls to re-use the logic in MoveUp/MoveDown by calling those functions directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using table.SetCursor to modify the location of the cursor in a table, the viewport wasn't getting updated in the same way as MoveUp/MoveDown which was causing the resulting View() to sometimes not include the cursor.
This changeset fixes this by internally converting any SetCursor calls to re-use the logic in MoveUp/MoveDown by calling those functions directly