feat: make the paginator key bindings customizable #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maaslalani
reviewed
Oct 7, 2022
paginator/paginator.go
Outdated
Comment on lines
56
to
65
| // UsePgUpPgDownKeys is deprecated. Customize KeyMap instead. | ||
| UsePgUpPgDownKeys bool | ||
| UseLeftRightKeys bool | ||
| UseUpDownKeys bool | ||
| UseHLKeys bool | ||
| UseJKKeys bool | ||
| // UseLeftRightKeys is deprecated. Customize KeyMap instead. | ||
| UseLeftRightKeys bool | ||
| // UseUpDownKeys is deprecated. Customize KeyMap instead. | ||
| UseUpDownKeys bool | ||
| // UseHLKeys is deprecated. Customize KeyMap instead. | ||
| UseHLKeys bool | ||
| // UseJKKeys is deprecated. Customize KeyMap instead. | ||
| UseJKKeys bool |
There was a problem hiding this comment.
From https://go.dev/blog/godoc
Sometimes a struct field, function, type, or even a whole package becomes redundant or unnecessary, but must be kept for compatibility with existing programs. To signal that an identifier should not be used, add a paragraph to its doc comment that begins with “Deprecated:” followed by some information about the deprecation.
|
This looks good to me behaviour wise since I did a quick code search on GitHub repos using the
|
maaslalani
approved these changes
Oct 7, 2022
knz
force-pushed
the
20221007-paginator
branch
from
0d7e4e2
to
1315fd7
Compare
maaslalani
approved these changes
Oct 7, 2022
knz
force-pushed
the
20221007-paginator
branch
from
1315fd7
to
dd720c6
Compare
|
Awesome work @knz, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #271.
This will also make the paginator benefit from the improvement in #261.
cc @maaslalani @meowgorithm