Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved performance, added individual cell toggle, and move column right/left #265

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

mathaou
Copy link

@mathaou mathaou commented Oct 5, 2022

I ended up not adding mouse support since that is only easy when in alt mode, so I'll add altmode/mouse support in a separate PR. This one is mainly to support arbitrarily large .csv files with thousands of rows and columns.

@mathaou
Copy link
Author

mathaou commented Oct 5, 2022

I realized I need to update for runewidth vs len(), I'll fix tomorrow

@mathaou
Copy link
Author

mathaou commented Oct 10, 2022

I actually didn't do any kind of figuring based on individual string lengths. I left the original API intact. The widths of each column is defined by the parent application, so this only touches slice lengths.

@bashbunni
Copy link
Member

bashbunni commented Oct 19, 2022

Thank you for the PR! It looks great.

I did a basic validation of the cell selection and navigation with ctrl+t - looks great, the only thing is the padding needs to get tweaked a bit (probably need to reset the styles when not in select cell mode) when we exit select cell mode back to the line selection. It seems to push the characters of the selected row off to the right by one character. Recording of behaviour attached.

bubbles-table-feedback.mov

Copy link
Member

@bashbunni bashbunni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • fix text alignment when switching back from CellSelect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants