New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved performance, added individual cell toggle, and move column right/left #265
base: master
Are you sure you want to change the base?
Conversation
I realized I need to update for runewidth vs len(), I'll fix tomorrow |
I actually didn't do any kind of figuring based on individual string lengths. I left the original API intact. The widths of each column is defined by the parent application, so this only touches slice lengths. |
Thank you for the PR! It looks great. I did a basic validation of the cell selection and navigation with bubbles-table-feedback.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- fix text alignment when switching back from
CellSelect
I ended up not adding mouse support since that is only easy when in alt mode, so I'll add altmode/mouse support in a separate PR. This one is mainly to support arbitrarily large .csv files with thousands of rows and columns.