Upgrade Rubocop #12
Merged
Upgrade Rubocop #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since version ~0.80, rubocop now warns you about new rules and you have to explicitly enable or disable them. I reviewed each of these rules and decided to keep them, primarily because I either liked what the rule did or it was trivial, autocorrectable, and I trust the rubocop/rails community. I’m open to changing any of the rules if they prove problematic. Docs: https://docs.rubocop.org/rubocop/0.85/versioning.html#pending-cops I tried upgrading to the latest version (0.86), but that resulted in some gem version conflicts that would’ve required upgrading capyabara, which I already decided I don’t want to deal with yet: charitywater/maji@dd9d67e BracesAroundHashParameters was removed: rubocop/rubocop#7641 [#172410772]
[#172410772]
[#172410772]
jasdeepgosal
force-pushed
the
upgrade-172410772
branch
from
89f2c0d
to
e236dc2
Compare
hjeebus
approved these changes
Jun 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since version ~0.80, rubocop now warns you about new rules and you have to explicitly enable or disable them.
I reviewed each of these rules and decided to keep them, primarily because I either liked what the rule did or it was trivial, autocorrectable, and I trust the rubocop/rails community. I’m open to changing any of the rules if they prove problematic.
Docs: https://docs.rubocop.org/rubocop/0.85/versioning.html#pending-cops
I tried upgrading to the latest version (0.86), but that resulted in some gem version conflicts that would’ve required upgrading capyabara, which I already decided I don’t want to deal with yet: https://github.com/charitywater/maji/pull/9460/commits/dd9d67ea89bfffcc93da97c012aee8c1ff69f389
BracesAroundHashParameters was removed: rubocop/rubocop#7641
[#172410772]