treat spaces as single-char bytes instead of strings for python 2/3 #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. I'm actually working on a large overhaul of chardet on this branch, so this will be actually unnecessary soon. |
|
The WIP to address this is #99. Closing this in favor of that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial state of self._prev is pretty suspect currently. python2 will gladly compare a string to an int (coming from wrap_ord()) and quietly return False. Likewise it will do tests for one char of a bytestring like:
b'x' in [ord(b'x')] # unexpectedly False
This patch fixes handling of the initial condition and comparing spaces but not the other issue of the class level character constants.