Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary guards for non-falsey values #259

Merged
merged 1 commit into from Jun 27, 2022
Merged

Remove unnecessary guards for non-falsey values #259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 3 additions & 8 deletions chardet/charsetgroupprober.py
View file
Open in desktop
Expand Up @@ -40,10 +40,9 @@ def reset(self):
super().reset()
self._active_num = 0
for prober in self.probers:
if prober:
prober.reset()
prober.active = True
self._active_num += 1
prober.reset()
prober.active = True
self._active_num += 1
self._best_guess_prober = None

@property
Expand All @@ -64,8 +63,6 @@ def language(self):

def feed(self, byte_str):
for prober in self.probers:
if not prober:
continue
if not prober.active:
continue
state = prober.feed(byte_str)
Expand All @@ -92,8 +89,6 @@ def get_confidence(self):
best_conf = 0.0
self._best_guess_prober = None
for prober in self.probers:
if not prober:
continue
if not prober.active:
self.logger.debug("%s not active", prober.charset_name)
continue
Expand Down
4 changes: 1 addition & 3 deletions chardet/escprober.py
View file
Open in desktop
Expand Up @@ -62,8 +62,6 @@ def __init__(self, lang_filter=None):
def reset(self):
super().reset()
for coding_sm in self.coding_sm:
if not coding_sm:
continue
coding_sm.active = True
coding_sm.reset()
self.active_sm_count = len(self.coding_sm)
Expand All @@ -84,7 +82,7 @@ def get_confidence(self):
def feed(self, byte_str):
for c in byte_str:
for coding_sm in self.coding_sm:
if not coding_sm or not coding_sm.active:
if not coding_sm.active:
continue
coding_state = coding_sm.next_state(c)
if coding_state == MachineState.ERROR:
Expand Down