Always remove XML tags when detecting single-byte charset encodings that use ASCII letters #208
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should prevent us from inadvertently having a bunch of XML/HTML tags influencing detection results.
Also rename
filter_with_english_letters
toremove_xml_tags
since that's what it actually does.This was originally part of #99 , but I'm trying to pull out the parts that didn't break there, so that all that's left is the model retraining in #99.