Fix some minor linting issues

chardet/charsetprober.py

@@ -52,8 +52,8 @@ def reset(self):
     def charset_name(self):
         return None
 
-    def feed(self, buf):
-        pass
+    def feed(self, byte_str):
+        raise NotImplementedError
 
     @property
     def state(self):

chardet/universaldetector.py

@@ -131,7 +131,7 @@ def feed(self, byte_str):
         if self.done:
             return
 
-        if not len(byte_str):
+        if not byte_str:
             return
 
         if not isinstance(byte_str, bytearray):
@@ -193,7 +193,7 @@ def feed(self, byte_str):
         if not self._utf1632_prober:
             self._utf1632_prober = UTF1632Prober()
 
-        if self._utf1632_prober.state() == ProbingState.DETECTING:
+        if self._utf1632_prober.state == ProbingState.DETECTING:
             if self._utf1632_prober.feed(byte_str) == ProbingState.FOUND_IT:
                 self.result = {
                     "encoding": self._utf1632_prober.charset_name,

chardet/utf1632prober.py

@@ -1,10 +1,4 @@
 ######################## BEGIN LICENSE BLOCK ########################
-# The Original Code is mozilla.org code.
-#
-# The Initial Developer of the Original Code is
-# Netscape Communications Corporation.
-# Portions created by the Initial Developer are Copyright (C) 1998
-# the Initial Developer. All Rights Reserved.
 #
 # Contributor(s):
 #   Jason Zavaglia
@@ -24,9 +18,8 @@
 # Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
 # 02110-1301  USA
 ######################### END LICENSE BLOCK #########################
-from chardet.enums import ProbingState
-
 from .charsetprober import CharSetProber
+from .enums import ProbingState
 
 
 class UTF1632Prober(CharSetProber):
@@ -202,13 +195,14 @@ def feed(self, byte_str):
             else:
                 self.nonzeros_at_mod[mod4] += 1
             self.position += 1
-        return self.state()
+        return self.state
 
+    @property
     def state(self):
-        if self._state in [ProbingState.NOT_ME, ProbingState.FOUND_IT]:
+        if self._state in {ProbingState.NOT_ME, ProbingState.FOUND_IT}:
             # terminal, decided states
             return self._state
-        elif self.get_confidence() > 0.80:
+        if self.get_confidence() > 0.80:
             self._state = ProbingState.FOUND_IT
         elif self.position > 4 * 1024:
             # if we get to 4kb into the file, and we can't conclude it's UTF,