Skip to content

Commit

Permalink
Remove shebang from nonexecutable script (#192)
Browse files Browse the repository at this point in the history
When packaging chardet and pip (which bundles it) in Fedora, we have realized
that there is a nonexecuatble file with a shebang line.

It seems that the primary purpose of this file is to be imported from Python
code or to be executed via python chardet/cli/chardetect.py or
python -m chardet.cli.chardetect and hence the shebang appears to be unnecessary.

Shebangs are hard to handle when doing downstream packaging, because it makes
sense for upstream to use #!/usr/bin/env python while in the RPM package, we
need to avoid that and use a more specific interpreter. Since the shebang was
unused, I propose to remove it to avoid the problems.
  • Loading branch information
hrnciar committed Dec 8, 2020
1 parent 5b1d7d5 commit 4650dbf
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion chardet/cli/chardetect.py
@@ -1,4 +1,3 @@
#!/usr/bin/env python
"""
Script which takes one or more file paths and reports on their detected
encodings
Expand Down

0 comments on commit 4650dbf

Please sign in to comment.