New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(api): use direct routes (#2066) #2072
chore(api): use direct routes (#2066) #2072
Conversation
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 52abcf8
|
@ti-srebot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Codecov Report
@@ Coverage Diff @@
## release-2.0 #2072 +/- ##
==============================================
Coverage ? 41.22%
==============================================
Files ? 127
Lines ? 7707
Branches ? 0
==============================================
Hits ? 3177
Misses ? 4224
Partials ? 306 Continue to review full report at Codecov.
|
cherry-pick #2066 to release-2.0
You can switch your code base to this Pull Request by using git-extras:
# In chaos-mesh repo: git pr https://github.com/chaos-mesh/chaos-mesh/pull/2072
After apply modifications, you can push your change to this PR via:
Signed-off-by: Yue Yang g1enyy0ung@gmail.com
What problem does this PR solve?
Close #1500.
Problem Summary
Since the gin-gonic/gin#2706 be merged. Now gin allows param and exact paths to existing on the same route level.
So all of the UI assets can be safely routed by
/
and/:foo/*bar
. This is almost the same as the/*any
.What is changed and how it works?
Except for all descriptions above, this PR also introduces some bug fixes and so on:
uid
indices in SQLitegorm.Model
to replace dummy fieldsRelated changes
Checklist
Tests
Side effects
Release note