Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(api): use direct routes (#2066) #2072

Merged

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jul 2, 2021

cherry-pick #2066 to release-2.0
You can switch your code base to this Pull Request by using git-extras:

# In chaos-mesh repo:
git pr https://github.com/chaos-mesh/chaos-mesh/pull/2072

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/chaos-mesh.git pr/2072:release-2.0-2c98e649556c

Signed-off-by: Yue Yang g1enyy0ung@gmail.com

What problem does this PR solve?

Close #1500.

Problem Summary

Since the gin-gonic/gin#2706 be merged. Now gin allows param and exact paths to existing on the same route level.

So all of the UI assets can be safely routed by / and /:foo/*bar. This is almost the same as the /*any.

What is changed and how it works?

Except for all descriptions above, this PR also introduces some bug fixes and so on:

  • Fix the problem of duplicate uid indices in SQLite
  • Use gorm.Model to replace dummy fields
  • Bump API server and UI versions
  • Some code formats

Related changes

  • Need to cheery-pick to the release branch

Checklist

Tests

  • Unit test
  • E2E test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Breaking backward compatibility

Release note

Please add a release note.
If you don't think this PR needs a release note then fill it with None.

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • STRRL
  • cwen0

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@cwen0
Copy link
Member

cwen0 commented Jul 6, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 52abcf8

@ti-chi-bot
Copy link
Member

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release-2.0@86609e5). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             release-2.0    #2072   +/-   ##
==============================================
  Coverage               ?   41.22%           
==============================================
  Files                  ?      127           
  Lines                  ?     7707           
  Branches               ?        0           
==============================================
  Hits                   ?     3177           
  Misses                 ?     4224           
  Partials               ?      306           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86609e5...d1dcd65. Read the comment docs.

@ti-chi-bot ti-chi-bot merged commit 69e80bb into chaos-mesh:release-2.0 Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants