Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 5397 nextjs self host font #6559

Merged
merged 2 commits into from
Jan 22, 2024
Merged

chore: 5397 nextjs self host font #6559

merged 2 commits into from
Jan 22, 2024

Conversation

tihuan
Copy link
Contributor

@tihuan tihuan commented Jan 19, 2024

Reason for Change

Changes

  1. Self host Inter font is faster than utilizing Google's CDN apparently (article)

Testing steps

  1. The whole app appear and function the same!

Checklist 🛎️

  • Add product, design, and eng as reviewers for rdev review
  • For UI changes, add screenshots/videos, so the reviewers know what you expect them to see
  • For UI changes, add e2e tests to prevent regressions

Notes for Reviewer

@tihuan tihuan requested a review from seve January 19, 2024 17:05
@tihuan tihuan marked this pull request as ready for review January 19, 2024 17:05
Copy link
Contributor

Deployment Summary

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2813c94) 92.12% compared to head (a246937) 92.12%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6559   +/-   ##
=======================================
  Coverage   92.12%   92.12%           
=======================================
  Files         180      180           
  Lines       14849    14849           
=======================================
  Hits        13679    13679           
  Misses       1170     1170           
Flag Coverage Δ
unittests 92.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tihuan tihuan requested a review from kaloster January 22, 2024 16:55
@tihuan tihuan enabled auto-merge (squash) January 22, 2024 16:55
Copy link
Contributor

@kaloster kaloster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tihuan tihuan merged commit 92c511f into main Jan 22, 2024
41 checks passed
@tihuan tihuan deleted the thuang-5397-next-font branch January 22, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants