Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Next.js 14 #5397

Closed
1 of 6 tasks
tihuan opened this issue Aug 4, 2023 · 5 comments
Closed
1 of 6 tasks

Upgrade to Next.js 14 #5397

tihuan opened this issue Aug 4, 2023 · 5 comments
Assignees
Labels
data-viz Data Viz Team frontend Frontend work P1 Priority 1 - Improvement with wide impact, fix within 1 week

Comments

@tihuan
Copy link
Contributor

tihuan commented Aug 4, 2023

NOTES:

  1. Next 13 by default uses React Server Component, which breaks MUI. So we need to explicitly add string "use client"; until MUI resolves the issue here
  2. Next14 has been released late October, so we're 2 major versions behind now
  3. We should migrate to use the new app router instead of page router as well (guide)

TASKS:

RESOURCES:

  1. Improve Next.js support mui/material-ui#34905 (comment)
@metakuni metakuni added the data-viz Data Viz Team label Oct 27, 2023
@tihuan tihuan changed the title Upgrade to Next.js 13 Upgrade to Next.js 14 Nov 20, 2023
@tihuan tihuan added frontend Frontend work P1 Priority 1 - Improvement with wide impact, fix within 1 week labels Nov 20, 2023
@tihuan
Copy link
Contributor Author

tihuan commented Nov 20, 2023

Set 5 points, since we need to follow the migration guide, migrate existing routes to the new app router, and make sure marking components with "use client" doesn't somehow break MUI or somehow miss marking "use client" at some places causing page specific runtime error

@tihuan tihuan self-assigned this Jan 3, 2024
@tihuan
Copy link
Contributor Author

tihuan commented Jan 9, 2024

Reading migration guide now to make sure the upgrade can be done efficiently. E.g., using code mods where possible

@tihuan
Copy link
Contributor Author

tihuan commented Jan 11, 2024

Created a new ticket to capture the need to incrementally migrate all routes:

https://app.zenhub.com/workspaces/single-cell-5e2a191dad828d52cc78b028/issues/gh/chanzuckerberg/single-cell-data-portal/6496

This ticket will start the migration with some examples

@tihuan
Copy link
Contributor Author

tihuan commented Jan 12, 2024

Looks like other people are struggling with the upgrade as well:

emotion-js/emotion#2928 (comment)

I think I'll just keep the routes in pages for now

@tihuan
Copy link
Contributor Author

tihuan commented Jan 17, 2024

Will have a followup PR to tackle Google Font and Metadata using the new Next.js API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data-viz Data Viz Team frontend Frontend work P1 Priority 1 - Improvement with wide impact, fix within 1 week
Projects
None yet
Development

No branches or pull requests

3 participants