Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin headlessui/react to 1.7.5 #1449

Merged
merged 1 commit into from Jan 5, 2023
Merged

Pin headlessui/react to 1.7.5 #1449

merged 1 commit into from Jan 5, 2023

Conversation

ahuth
Copy link
Contributor

@ahuth ahuth commented Jan 4, 2023

Pin headlessui/react to 1.7.5, to resolve E2E test failures in https://github.com/FB-PLP/traject/pull/13040.

Seeing

Error: RangeError: Maximum call stack size exceeded.
      at HTMLDocument.enforceFocus (http://localhost:3003/javascripts/js/vendor.js:134963:21)
      at S (http://localhost:3003/javascripts/js/vendor.js:162697:1335)
      at onBlur (http://localhost:3003/javascripts/js/vendor.js:161872:2651)
      at onBlur (http://localhost:3003/javascripts/js/vendor.js:162820:954)
      at HTMLUnknownElement.callCallback (http://localhost:3003/javascripts/js/vendor.js:110567:14)
      at Object.invokeGuardedCallbackDev (http://localhost:3003/javascripts/js/vendor.js:110616:16)
      at invokeGuardedCallback (http://localhost:3003/javascripts/js/vendor.js:110678:31)
      at invokeGuardedCallbackAndCatchFirstError (http://localhost:3003/javascripts/js/vendor.js:110692:25)
      at executeDispatch (http://localhost:3003/javascripts/js/vendor.js:114865:3)
      at processDispatchQueueItemsInOrder (http://localhost:3003/javascripts/js/vendor.js:114897:7)

The HTMLDocument.enforceFocus makes me think this could be 2 different focus traps fighting for focus.


This issue first shows up in headlessui/react 1.7.6.

The most suspicious changelog item is "Fix FocusTrap escape due to strange tabindex values" from tailwindlabs/headlessui#2093.

In any case, we should merge this PR to unblock updating EDS in Traject. A future effort can look at resolving unpinning.

@ahuth ahuth changed the base branch from main to next January 4, 2023 23:14
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

size-limit report

Path Size
components 123.95 KB (0%)
styles 3.1 KB (-6.69% 🔽)

@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Merging #1449 (67849cd) into next (a0d6143) will not change coverage.
The diff coverage is n/a.

❗ Current head 67849cd differs from pull request most recent head 41b11b4. Consider uploading reports for the commit 41b11b4 to get more accurate results

@@           Coverage Diff           @@
##             next    #1449   +/-   ##
=======================================
  Coverage   91.62%   91.62%           
=======================================
  Files         321      321           
  Lines        4619     4619           
  Branches      822      822           
=======================================
  Hits         4232     4232           
  Misses        357      357           
  Partials       30       30           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Resolves e2e test failures in Traject (see FB-PLP/traject#13040).

Issue starts in 1.7.6, possibly from tailwindlabs/headlessui#2093.
@ahuth ahuth marked this pull request as ready for review January 5, 2023 14:36
@ahuth ahuth requested a review from a team January 5, 2023 14:36
@ahuth ahuth changed the title Try downgrading things Pin headlessui/react to 1.7.5 Jan 5, 2023
@ahuth
Copy link
Contributor Author

ahuth commented Jan 5, 2023

@chanzuckerberg/edu-frontend-infra this is ready to go 🙏

Copy link
Contributor

@jinlee93 jinlee93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fast investigation

@ahuth
Copy link
Contributor Author

ahuth commented Jan 5, 2023

Thanks!

@ahuth ahuth merged commit 9539229 into next Jan 5, 2023
@ahuth ahuth deleted the ah-try-downgrading-things branch January 5, 2023 17:03
@booc0mtaco
Copy link
Contributor

@jinlee93 i think this was the version where we started seeing those weird warnings in EDS too...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants