Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure preview is ready before moving on to extract #94

Merged
merged 2 commits into from
May 13, 2024
Merged

Ensure preview is ready before moving on to extract #94

merged 2 commits into from
May 13, 2024

Conversation

czibbelvin
Copy link
Contributor

Currently, extract can be called before the preview is ready. By waiting on ready, it ensures extract will succeed.

From logs:

Please check that...
- You're using a compatible version of Storybook
- Storybook doesn't have any errors

Otherwise this is likely a bug with axe-storybook-testing.

Original error message: Error: page.evaluate: SB_PREVIEW_API_0005 (CalledPreviewMethodBeforeInitializationError): Called `Preview.extract()` before initialization.

ahuth
ahuth approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@ahuth ahuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

@ahuth ahuth merged commit 2a92e05 into chanzuckerberg:main May 13, 2024
2 checks passed
@ahuth
Copy link
Collaborator

ahuth commented May 13, 2024

Published in v8.0.2

@booc0mtaco booc0mtaco requested a review from ahuth May 13, 2024 15:03
@ahuth ahuth mentioned this pull request May 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahuth ahuth Awaiting requested review from ahuth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@czibbelvin @ahuth