Some updates #93
Merged
Some updates #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ahuth
commented
Mar 21, 2024
ahuth
commented
- Refactors to storybook event handling
- Refactors to function return values
- Upgrade storybook
- Upgrade all the other deps, too
- Validate against the public EDS storybook on CI (non-blocking)
In my mind, this removes any possibility that the storyRendered event is emmitted back before the microtask has ran and we have had a chance to set up the event listener... Probably not really a possibility, but why not.
I previously didn't add this because EDS's storybook is out of our control, and I don't want the tests here to start failing if something gets borked over there. But I figure now that it's fine to add a non-blocking check as another validation on any changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.