Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build for Node 18 #91

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Build for Node 18 #91

merged 1 commit into from
Mar 5, 2024

Conversation

ahuth
Copy link
Collaborator

@ahuth ahuth commented Mar 5, 2024

Raise the min supported Node version from 12 to 18.

@ahuth ahuth requested a review from a team March 5, 2024 13:08
@ahuth ahuth merged commit 8148c8a into main Mar 5, 2024
2 checks passed
@ahuth ahuth deleted the ah-node-18 branch March 5, 2024 13:11
@jeremiah-clothier
Copy link
Contributor

jeremiah-clothier commented Mar 5, 2024

Would adding the engines property be worthwhile? I know it's a documented property but not sure what the dev experience of the property actually is and how it would change npm install behavior for someone with node < 18

https://docs.npmjs.com/cli/v10/configuring-npm/package-json#engines

@ahuth
Copy link
Collaborator Author

ahuth commented Mar 5, 2024

I don't love putting engines in, because it might work on other versions of node (depends on what features I used). Figure it's best to document what version is supported, but let people try with whatever version they want.

@ahuth
Copy link
Collaborator Author

ahuth commented Mar 5, 2024

Although technically it would still work with engines unless someone configures engines-strict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants