Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enchance to add @layer components at-rule in CSS post-processing #1887

Merged
merged 8 commits into from Jan 9, 2024

Conversation

sungik-choi
Copy link
Contributor

@sungik-choi sungik-choi commented Jan 8, 2024

Self Checklist

  • I wrote a PR title in English and added an appropriate label to the PR.
  • I wrote the commit message in English and to follow the Conventional Commits specification.
  • I added the changeset about the changes that needed to be released. (or didn't have to)
  • I wrote or updated documentation related to the changes. (or didn't have to)
  • I wrote or updated tests related to the changes. (or didn't have to)
  • I tested the changes in various browsers. (or didn't have to)
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox

Related Issue

Summary

Enchance to add @layer components at-rule in CSS post-processing

Details

  • 커스텀 PostCSS plugin을 통해 CSS를 갈아끼우는 방식으로 구현했습니다. 구현은 단순합니다.
  • 불필요해진 *.module.scss의 @layer components at-rule을 제거했습니다.
  • *.module.scss + components 디렉토리 내부에 위치한 파일만 처리하도록 구현했습니다. 여기엔 layout, margin props도 포함되니 이후 디렉터리명 변경에 유의해야합니다.
  • 이전/이후 빌드된 CSS 파일이 동일한 것을 확인했습니다.

Breaking change? (Yes/No)

No

References

Copy link

changeset-bot bot commented Jan 8, 2024

⚠️ No Changeset found

Latest commit: 78a6842

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 8, 2024

Chromatic Report

🚀 Congratulations! Your build was successful!

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7b4fb30) 86.20% compared to head (78a6842) 86.20%.

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha    #1887   +/-   ##
=======================================
  Coverage   86.20%   86.20%           
=======================================
  Files         254      254           
  Lines        3530     3530           
  Branches      770      770           
=======================================
  Hits         3043     3043           
  Misses        403      403           
  Partials       84       84           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sungik-choi sungik-choi changed the title Build/auto layer postcss Enchance to add @layer components at-rule in CSS post-processing Jan 9, 2024
@sungik-choi sungik-choi changed the title Enchance to add @layer components at-rule in CSS post-processing Enchance to add @layer components at-rule in CSS post-processing Jan 9, 2024
@sungik-choi sungik-choi self-assigned this Jan 9, 2024
@sungik-choi sungik-choi added build Issue or PR related to build system enhancement Issues or PR related to making existing features better labels Jan 9, 2024
@sungik-choi sungik-choi marked this pull request as ready for review January 9, 2024 04:16
@sungik-choi
Copy link
Contributor Author

sungik-choi commented Jan 9, 2024

PostCSS를 들어내고 Lightning CSS로 갈아끼우고, Lightning CSS 플러그인을 구현할까 생각해봤는데...

  • Vite에서도 아직 실험적 기능임 (https://ko.vitejs.dev/guide/features.html#lightning-css)
  • SCSS를 사용 못함 (전처리기 지원을 안함). 현재 사용하고 있는 rollup postcss plugin을 scss 처리 직접 구현 -> output css를 사용하는 방식으로 변경해서 구현이 가능할텐데, rollup이랑 통합하는데 드는 비용 대비 얻는 이득이 굉장히 작을 거라고 판단

sungik-choi added a commit to sungik-choi/bezier-react that referenced this pull request Jan 9, 2024
@sungik-choi sungik-choi merged commit 9cccddc into channel-io:alpha Jan 9, 2024
11 checks passed
@sungik-choi sungik-choi deleted the build/auto-layer-postcss branch January 9, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issue or PR related to build system enhancement Issues or PR related to making existing features better
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Enchance to add @layer components at-rule in CSS post-processing
2 participants