[Feature] Support NX Monorepos #801
Conversation
Adds a fixture for validating if we can discover available NX packages
- Set up initial logic with async getWorkspaces - Get typings correct for new Tool - Prepare logic for returning Package types - Set up test for TDD on adding @nrwl/devkit
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a8fe805:
|
| "nx": "*" | ||
| }, | ||
| "peerDependencies": { | ||
| "@nrwl/devkit": "*", |
There was a problem hiding this comment.
is it always explicitly installed by Nx users? 🤔
| @@ -1,16 +1,30 @@ | |||
| { | |||
| "name": "get-workspaces", | |||
| "name": "@changesets/get-workspaces", | |||
There was a problem hiding this comment.
In general @manypkg/get-packages is also under our control - so any logic that tries to find packages in a given monorepo should be added there. Given this situation I don't think there is any strong reason to create @changesets/get-workspaces
|
Hello @brianespinosa 👋 just wondering when would we expect for this change to be available? |
|
@Andarist any news on this? |
|
It would be great to see this come into action. We are currently in the progress of making use of mono-repos and are considering nx. Nx does mention changesets in their documentation for version management, but how they expect this to actually work is not known to me. |
|
I am going to go ahead and decline this PR as I think there is a better approach that is more extensible as proposed in #849 |
Resolves #800
WIP. Creating a draft PR for visibility, and for CI. Includes an NX fixture repo and tests. Two expect statements to get green and then add the NX fixture use case to other packages to verify NX works there as well.
I might get a chance to come back and finish this evening.