Improve error handling when an invalid release type is specified in a changeset #1260
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When specifying a release type, if an invalid type is specified, such as
feat
, then a relatively unhelpful error is shown to the user:This occurs because the key
feat
is not present in this object, so it tries topush
toundefined
rather than an empty array.I've added a small check to validate the release type and show an immediately actionable error if the type is invalid:
Happy to work with a maintainer on an alternate solution if this is too naive/doesn't handle some edge cases I'm unaware of.