Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for the changedFilePatterns config #1033

Merged
merged 7 commits into from Dec 18, 2022
Merged

Add support for the changedFilePatterns config #1033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e3af61d
Add support for the `changedFilesPatterns` config
Andarist Dec 14, 2022
74f7dd1
fixed type errors
Andarist Dec 14, 2022
b769afd
fixed formatting
Andarist Dec 14, 2022
08a343a
add missing dev dep
Andarist Dec 14, 2022
b18d97a
Rename the new config option to `changedFilePatterns`
Andarist Dec 18, 2022
efb4b7c
Add changesets
Andarist Dec 18, 2022
1d229e0
Merge branch 'main' into andarist/changed-files-patterns
Andarist Dec 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/eighty-schools-admire.md
View file
Open in desktop
@@ -0,0 +1,5 @@
---
"@changesets/config": minor
---

Support and validation for the new `changedFilePatterns` option has been added.
5 changes: 5 additions & 0 deletions .changeset/healthy-rats-chew.md
View file
Open in desktop
@@ -0,0 +1,5 @@
---
"@changesets/git": minor
---

`getChangedPackagesSinceRef` accepts now a new `changedFilePatterns` option. It can be used to determine which packages should be classified as changed. You can pass an array of glob patterns to it.
5 changes: 5 additions & 0 deletions .changeset/spicy-apes-visit.md
View file
Open in desktop
@@ -0,0 +1,5 @@
---
"@changesets/types": patch
---

Added `changedFilePatterns` property to `Config` and `WrittenConfig` types.
14 changes: 14 additions & 0 deletions .changeset/wicked-years-share.md
View file
Open in desktop
@@ -0,0 +1,14 @@
---
"@changesets/cli": minor
---

A new config-level `changedFilePatterns` option has been added. You can configure it with an array of glob patterns like here:

```json
// .changeset/config.json
{
"changedFilePatterns": ["src/**"]
}
```

Files that do not match the configured pattern won't contribute to the "changed" status of the package to which they belong. This both affects `changesets add` and `changeset status`.
18 changes: 18 additions & 0 deletions packages/apply-release-plan/src/index.test.ts
View file
Open in desktop
Expand Up @@ -47,6 +47,7 @@ class FakeReleasePlan {
fixed: [],
linked: [],
access: "restricted",
changedFilePatterns: ["**"],
baseBranch: "main",
updateInternalDependencies: "patch",
ignore: [],
Expand Down Expand Up @@ -89,6 +90,7 @@ async function testSetup(
fixed: [],
linked: [],
access: "restricted",
changedFilePatterns: ["**"],
baseBranch: "main",
updateInternalDependencies: "patch",
ignore: [],
Expand Down Expand Up @@ -661,6 +663,7 @@ describe("apply release plan", () => {
linked: [],
access: "restricted",
baseBranch: "main",
changedFilePatterns: ["**"],
updateInternalDependencies: "patch",
privatePackages: { version: true, tag: false },
ignore: [],
Expand Down Expand Up @@ -736,6 +739,7 @@ describe("apply release plan", () => {
linked: [],
access: "restricted",
baseBranch: "main",
changedFilePatterns: ["**"],
updateInternalDependencies: "patch",
privatePackages: { version: true, tag: false },
ignore: [],
Expand Down Expand Up @@ -992,6 +996,7 @@ describe("apply release plan", () => {
fixed: [],
linked: [],
access: "restricted",
changedFilePatterns: ["**"],
baseBranch: "main",
updateInternalDependencies,
ignore: [],
Expand Down Expand Up @@ -1107,6 +1112,7 @@ describe("apply release plan", () => {
fixed: [],
linked: [],
access: "restricted",
changedFilePatterns: ["**"],
baseBranch: "main",
updateInternalDependencies,
ignore: [],
Expand Down Expand Up @@ -1207,6 +1213,7 @@ describe("apply release plan", () => {
fixed: [],
linked: [],
access: "restricted",
changedFilePatterns: ["**"],
baseBranch: "main",
updateInternalDependencies,
ignore: [],
Expand Down Expand Up @@ -1306,6 +1313,7 @@ describe("apply release plan", () => {
fixed: [],
linked: [],
access: "restricted",
changedFilePatterns: ["**"],
baseBranch: "main",
updateInternalDependencies,
ignore: [],
Expand Down Expand Up @@ -1408,6 +1416,7 @@ describe("apply release plan", () => {
fixed: [],
linked: [],
access: "restricted",
changedFilePatterns: ["**"],
baseBranch: "main",
updateInternalDependencies,
ignore: [],
Expand Down Expand Up @@ -1523,6 +1532,7 @@ describe("apply release plan", () => {
fixed: [],
linked: [],
access: "restricted",
changedFilePatterns: ["**"],
baseBranch: "main",
updateInternalDependencies,
ignore: [],
Expand Down Expand Up @@ -1631,6 +1641,7 @@ describe("apply release plan", () => {
fixed: [],
linked: [],
access: "restricted",
changedFilePatterns: ["**"],
baseBranch: "main",
updateInternalDependencies,
ignore: [],
Expand Down Expand Up @@ -1730,6 +1741,7 @@ describe("apply release plan", () => {
fixed: [],
linked: [],
access: "restricted",
changedFilePatterns: ["**"],
baseBranch: "main",
updateInternalDependencies,
ignore: [],
Expand Down Expand Up @@ -1830,6 +1842,7 @@ describe("apply release plan", () => {
fixed: [],
linked: [],
access: "restricted",
changedFilePatterns: ["**"],
baseBranch: "main",
updateInternalDependencies: "patch",
ignore: [],
Expand Down Expand Up @@ -2058,6 +2071,7 @@ describe("apply release plan", () => {
linked: [],
access: "restricted",
baseBranch: "main",
changedFilePatterns: ["**"],
changelog: [
path.resolve(__dirname, "test-utils/simple-get-changelog-entry"),
null,
Expand Down Expand Up @@ -2198,6 +2212,7 @@ describe("apply release plan", () => {
fixed: [],
linked: [],
access: "restricted",
changedFilePatterns: ["**"],
baseBranch: "main",
updateInternalDependencies: "patch",
ignore: [],
Expand Down Expand Up @@ -2306,6 +2321,7 @@ describe("apply release plan", () => {
fixed: [],
linked: [],
access: "restricted",
changedFilePatterns: ["**"],
baseBranch: "main",
updateInternalDependencies: "minor",
ignore: [],
Expand Down Expand Up @@ -2426,6 +2442,7 @@ describe("apply release plan", () => {
fixed: [],
linked: [],
access: "restricted",
changedFilePatterns: ["**"],
baseBranch: "main",
updateInternalDependencies: "minor",
ignore: [],
Expand Down Expand Up @@ -2560,6 +2577,7 @@ describe("apply release plan", () => {
fixed: [],
linked: [],
access: "restricted",
changedFilePatterns: ["**"],
baseBranch: "main",
updateInternalDependencies: "minor",
ignore: [],
Expand Down
1 change: 1 addition & 0 deletions packages/cli/src/commands/add/index.ts
View file
Open in desktop
Expand Up @@ -42,6 +42,7 @@ export default async function add(
const changedPackages = await git.getChangedPackagesSinceRef({
cwd,
ref: config.baseBranch,
changedFilePatterns: config.changedFilePatterns,
});
const changedPackagesName = changedPackages
.filter((pkg) => isListablePackage(config, pkg.packageJson))
Expand Down