Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the success message shorter #80

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Make the success message shorter #80

wants to merge 3 commits into from

Conversation

eoghanmurray
Copy link

Make the success message shorter than the failure message and tweak the visuals to better distinguish the two.

Ref #79

@vercel Vercel
Copy link

vercel bot commented Nov 7, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changesets-bot ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2023 3:51pm

@eoghanmurray
Copy link
Author

  • in the absent version, does the getReleasePlanMessage(releasePlan) always return the 'when changesets are added to this PR...' message? If so, then that could be inlined and made visually distinctive (rather than both messages having a bit that is expandable)
  • I looked at the git log but couldn't really see the reason for including the ${commitSha} in either the absent or the approve message; removing from only the approve message for brevity

@eoghanmurray
Further make the 'success' version shorter. Think the tick mark is mo…
451eddf 
…re important than the butterflies, as the butterfly is already there in the bot icon
@eoghanmurray eoghanmurray mentioned this pull request Nov 8, 2023
Open
@eoghanmurray
Copy link
Author

What current iteration of ths PR looks like:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmatown emmatown Awaiting requested review from emmatown emmatown is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@eoghanmurray