Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unignore dist on main branch #243

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

robertkowalski
Copy link

currently the ignore is not needed on the main branch and we are running into a bug with nektos/act which uses the go-git library.

go-git/go-git#633

currently the ignore is not needed on the main branch and we are running into a bug with nektos/act which uses the go-git library.

go-git/go-git#633
@changeset-bot
Copy link

changeset-bot bot commented Dec 13, 2022

⚠️ No Changeset found

Latest commit: 3a44530

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Andarist
Copy link
Member

Without ignoring this we will end up with constant merge conflicts. Each PR merged will create conflicts in all pending ones. I'd really like to avoid that - it's super frustrating, especially when it happens to the community PRs

Is there any open issue in nectos/act related to this?

@robertkowalski
Copy link
Author

@Andarist not yet, we opened one in go-git as the error originates from there: go-git/go-git#633

@Andarist
Copy link
Member

I would wait for that issue to be resolved first then. How do you end up with this problem in the first place though? I don't quite understand the full e2e scenario that you are facing. Is nektos/act fetching our main branch and then switching to the "requested" ref? I assume that you are using changesets/actions@v1 or something like that and not changesets/action@main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants