Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/99 add coreui theme #135

Merged
merged 151 commits into from
Jan 21, 2019
Merged

Feature/99 add coreui theme #135

merged 151 commits into from
Jan 21, 2019

Conversation

pixeljunkie
Copy link
Contributor

Q A
Branch master
Bug fix? no
New feature? yes
BC breaks? yes
Deprecations? yes
Tests pass? yes
Fixed issues chameleon-system/chameleon-system#99
License MIT

BC Breaks: yes and no... the backend jquery library is updated and some jquery ui components are not used anymore. The files are available for your custom extensions, but you should replace them with bootstrap components.

pixeljunkie and others added 30 commits November 14, 2018 10:57
…eprecated in 6.2 but this file missed the deprecation flag)
…vent inline JS (inludes a code reformat of the file)
umulmrum pushed a commit that referenced this pull request Jan 16, 2019
* ref #135: Add cron job enabling (commands and services)

* ref #135: cs fix

* Update src/CoreBundle/Bridge/Chameleon/Migration/Script/update-1543820426.inc.php

Co-Authored-By: UlrichKu <ulrich.kuhn@esono.de>

* Update src/CoreBundle/Bridge/Chameleon/Migration/Script/update-1543820426.inc.php

Co-Authored-By: UlrichKu <ulrich.kuhn@esono.de>

* ref #135: Change wording and language

* Update src/CoreBundle/CronJob/CronjobEnablingServiceInterface.php

Co-Authored-By: UlrichKu <ulrich.kuhn@esono.de>

* Update src/CoreBundle/private/modules/CMSRunCrons/CMSRunCrons.class.php

Co-Authored-By: UlrichKu <ulrich.kuhn@esono.de>

* ref #135: Comma change

* Update src/CoreBundle/CronJob/CronjobEnablingServiceInterface.php

Co-Authored-By: UlrichKu <ulrich.kuhn@esono.de>

* ref #135: Correct wording / sentence parts

* ref #135: Remove unnecessary index

* ref #135: Correct method name

* ref #135: Add log message if cronjobs disabled during loop

* ref #135: Remove issue number

* ref #135: Only log info message

* ref #135: Finish method renaming

* ref #135: Do not force load config if not needed - refreshing should be done on save elsewhere

* ref #135: Show appropriate errors for a single cronjob; log appropriately for all cronjob execution

* ref #135: cs fix

* Update src/CoreBundle/private/modules/CMSRunCrons/CMSRunCrons.class.php

Co-Authored-By: UlrichKu <ulrich.kuhn@esono.de>

* ref #135: Display translated texts

* ref #135: Correct todo

* ref #135: Add note

* ref #135: cs fix

* ref #135: Remove non-helping NOTE; add message plainly

* ref #135: Correct variable name

* ref #135: Improve wording

Co-Authored-By: UlrichKu <ulrich.kuhn@esono.de>
UlrichKu added a commit to UlrichKu/chameleon-base that referenced this pull request Jan 17, 2019
UlrichKu added a commit to UlrichKu/chameleon-base that referenced this pull request Jan 17, 2019
UlrichKu added a commit to UlrichKu/chameleon-base that referenced this pull request Jan 17, 2019
@pixeljunkie pixeljunkie assigned umulmrum and unassigned pixeljunkie Jan 17, 2019
@@ -55,13 +61,13 @@ MIT License

- Foundation Icon Font - https://github.com/zurb/foundation-icons
- Ionicons - http://ionicons.com/
- Font Awesome - https://fontawesome.com/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes yet :-)

THIRD-PARTY-LICENSE Outdated Show resolved Hide resolved
UPGRADE-6.3.md Show resolved Hide resolved
});

$('[data-select2-option]').each(function () {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes yet :-)

@@ -61,6 +61,11 @@ Note that ONLY BC breaking changes are listed, according to our backwards compat
- New method `getDomainDataByName()`.
- New method `getPortalPrefixListForDomain()`.

## TCMSFieldDate/TCMSFieldDateToday

The field classes now use the language independent SQL date format in frontend rendering instead of always using a german date format.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes yet :-)

@umulmrum umulmrum assigned pixeljunkie and unassigned umulmrum Jan 17, 2019
@pixeljunkie pixeljunkie assigned umulmrum and unassigned pixeljunkie Jan 17, 2019
@umulmrum umulmrum merged commit d6f7239 into chameleon-system:master Jan 21, 2019
@umulmrum
Copy link
Contributor

Thanks @pixeljunkie

umulmrum pushed a commit that referenced this pull request Jan 28, 2019
* ref #135: Add log message if cronjobs disabled during loop

* ref #134: Get information if a cron job is running

* ref #134: Remove debug code

* ref #135: Add note

* ref #135: Remove non-helping NOTE; add message plainly

* ref #134: Rename command, state and output

* ref #134: Use new cronjob state service

* ref #134: Add license header

Co-Authored-By: UlrichKu <ulrich.kuhn@esono.de>
@pixeljunkie pixeljunkie deleted the feature/99-add-coreui-theme branch January 29, 2019 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants