Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fixed number of iterations from benchmark.js #406

Merged
merged 1 commit into from Nov 20, 2020

Conversation

toonijn
Copy link
Contributor

@toonijn toonijn commented Jun 9, 2020

As suggested in #392 (comment) the fixed number of iterations is removed.

@Qix- There are two possibilities:

set('iterations', 100);     // the number of times to run a given bench
set('concurrency', 1);      // the number of how many times a given bench is run concurrently
set('type', 'adaptive');    // or 'static' (see below)
set('mintime', 500);        // when adaptive, the minimum time in ms a bench should run
set('delay', 100);          // time in ms between each bench
  • Or we could provide our own.

I like the defaults best. So I just removed the two lines where we fix the number of iterations.

Copy link
Member

@Qix- Qix- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. The maintainers of that library are going to know the best defaults for such benchmarks.

Thanks for opening the PR :)

@Qix- Qix- merged commit 72299f9 into chalk:master Nov 20, 2020
@Qix-
Copy link
Member

Qix- commented Nov 20, 2020

Thanks, apologies for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants