Disallow template literals on colors and modifiers in the TypeScript types #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any feedback on this? PR was submitted over 3 weeks ago |
sindresorhus
changed the title
sindresorhus
changed the title
|
@ExE-Boss Can you help review? |
sindresorhus
reviewed
Mar 3, 2020
| @@ -398,7 +411,7 @@ Call the last one as a method with a string argument. | |||
| Order doesn't matter, and later styles take precedent in case of a conflict. | |||
| This simply means that `chalk.red.yellow.green` is equivalent to `chalk.green`. | |||
| */ | |||
| declare const chalk: chalk.Chalk & chalk.ChalkFunction & { | |||
| declare const chalk: chalk.Chalk & chalk.ChalkFunction & chalk.ChalkTemplateFunction & { | |||
There was a problem hiding this comment.
Isn't & chalk.ChalkFunction & chalk.ChalkTemplateFunction moot here as chalk.Chalk already extend those?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #341