Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website/omni-search): correct the usage of useEventListener #8491

Merged
merged 1 commit into from
May 18, 2024

Conversation

TylerAPfledderer
Copy link
Collaborator

Closes #8490

⛳️ Current behavior (updates)

In the omni-search component of the docsite, the useEventListener hook for the keyboard shortcut to open the search modal has incorrect arguments applied to the first two parameters, resulting in the entire hook failing.

🚀 New behavior

Move the two arguments to the second and third param. The first param is looking for a target object which is not needed and can be defined null. The second param needs the string keydown because that is the mapped event name. And the third param needs the actual event handling.

📝 Additional Information

The current broken behavior will still impact the site when it shifts over to Chakra v3

@TylerAPfledderer TylerAPfledderer added the Topic: Website 🖥 Issues and PRs relating to the Chakra UI website label May 18, 2024
Copy link

vercel bot commented May 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
chakra-ui-storybook ✅ Ready (Inspect) Visit Preview May 18, 2024 1:38am
chakra-ui-website ✅ Ready (Inspect) Visit Preview May 18, 2024 1:38am

Copy link

changeset-bot bot commented May 18, 2024

⚠️ No Changeset found

Latest commit: b69a796

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@TylerAPfledderer TylerAPfledderer self-assigned this May 18, 2024
@TylerAPfledderer TylerAPfledderer merged commit 3f05ea2 into v2 May 18, 2024
2 checks passed
@TylerAPfledderer TylerAPfledderer deleted the fix/website-search-event-handler branch May 18, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Topic: Website 🖥 Issues and PRs relating to the Chakra UI website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant