New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add semantic token support for data-theme attributes #5532
Conversation
🦋 Changeset detectedLatest commit: ab16166 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ab16166:
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui-storybook/4frBTjyEetekobd2SnXEXdVo3hWN |
📦 A new release has been made for this pull requestTo play around with this release, you can install
|
d2ad43e
to
ac54330
Compare
…ponents" This reverts commit ac54330.
ac54330
to
00d5d15
Compare
Relates to #5526
📝 Description
This PR allows the semantic tokens to react to
data-theme="dark"
anddata-theme="light"
DOM attributes.[data-theme]
to the CSS variables root selector⛳️ Current behavior (updates)
Semantic tokens can only react to "environmental" / global CSS conditions.
🚀 New behavior
To use the
LightMode
andDarkMode
components with those changes, add an additional DOM element with the attributedata-theme="<color-mode>"
attached.💣 Is this a breaking change (Yes/No):
No