Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update rust toolchain #1578

Merged
merged 2 commits into from
Apr 27, 2022
Merged

Conversation

dandanlen
Copy link
Collaborator

@dandanlen dandanlen commented Apr 27, 2022

This fixes a bug with rust analyzer, see
rust-lang/rust-analyzer#10772

CI doesn't like this - anything else I need to do to get this to work?
Any other objections to updating this?

(@tomjohnburton @AlastairHolmes)

@morelazers
Copy link

morelazers commented Apr 27, 2022

CI will need to update the rust-base image. @tomjohnburton or @ahasna can one of you make a new tag (or update 2021)?

@ahasna
Copy link
Contributor

ahasna commented Apr 27, 2022

Sure! on it

ahasna added a commit that referenced this pull request Apr 27, 2022
@ahasna ahasna closed this in 39de801 Apr 27, 2022
@ahasna ahasna reopened this Apr 27, 2022
@ahasna
Copy link
Contributor

ahasna commented Apr 27, 2022

sorry for closing this by mistake @dandanlen
I didn't know that mentioning the issue in a commit would close it 😅

Rust base image was updated in #1578 and tagged as latest

Closes #1578
@morelazers morelazers merged commit da3bbf7 into develop Apr 27, 2022
@morelazers morelazers deleted the chore/update-rust-toolchain branch April 27, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants