Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sphinx version to 1.7.9 #5359

Merged
merged 1 commit into from
Sep 17, 2018
Merged

Fix sphinx version to 1.7.9 #5359

merged 1 commit into from
Sep 17, 2018

Conversation

mitmul
Copy link
Member

@mitmul mitmul commented Sep 16, 2018

It looks the newer version of sphinx is causing test errors in Travis tests for MacOS.

@kmaehashi
Copy link
Member

Jenkins, test this please.

@kmaehashi kmaehashi added cat:document Documentation such as function documentations, comments and tutorials. to-be-backported Pull request that should be backported. st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. labels Sep 16, 2018
@kmaehashi kmaehashi added this to the v5.0.0rc1 milestone Sep 16, 2018
@chainer-ci
Copy link
Member

Jenkins CI test (for commit 956a99e, target branch master) succeeded!

@kmaehashi kmaehashi merged commit ef68b6c into chainer:master Sep 17, 2018
@kmaehashi
Copy link
Member

LGTM!

@chainer-ci
Copy link
Member

@kmaehashi This pull-request is marked as to-be-backported, but the corresponding backport PR could not be found. Could you check?

@mitmul mitmul deleted the fix-make-docs-errors branch September 17, 2018 03:07
@chainer-ci
Copy link
Member

@kmaehashi This pull-request is marked as to-be-backported, but the corresponding backport PR could not be found. Could you check?

@hvy hvy removed the to-be-backported Pull request that should be backported. label Sep 27, 2018
@hvy
Copy link
Member

hvy commented Sep 27, 2018

Could not backport before release so I removed the label.

@toslunar
Copy link
Member

toslunar commented Nov 1, 2018

It seems sphinx-doc/sphinx#5510 fixed the issue (sphinx>=1.8.2, which hasn't been released).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kmaehashi kmaehashi

Labels
cat:document Documentation such as function documentations, comments and tutorials. st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes.
Projects
None yet
Milestone
v5.0.0rc1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mitmul @kmaehashi @chainer-ci @hvy @toslunar