-
-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate to typescript #1567
Draft
43081j
wants to merge
11
commits into
chaijs:main
Choose a base branch
from
43081j:typescript
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Commits on May 4, 2024
-
This is an initial attempt at migrating the codebase to typescript. The tests and build should pass but we can go further and do more with the types. WIP until we do that.
Configuration menu - View commit details
-
Copy full SHA for 8c96ee8 - Browse repository at this point
Copy the full SHA 8c96ee8View commit details -
fix: use
never
for method argsThis way, we can hold them in a non-generic array without the need for `any`. Later, when we need to call the method, we will have to cast it to a callable signature.
Configuration menu - View commit details
-
Copy full SHA for 4f0ea45 - Browse repository at this point
Copy the full SHA 4f0ea45View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f54d68 - Browse repository at this point
Copy the full SHA 3f54d68View commit details -
Configuration menu - View commit details
-
Copy full SHA for 562e098 - Browse repository at this point
Copy the full SHA 562e098View commit details -
Configuration menu - View commit details
-
Copy full SHA for 86721ec - Browse repository at this point
Copy the full SHA 86721ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 308cfab - Browse repository at this point
Copy the full SHA 308cfabView commit details -
Configuration menu - View commit details
-
Copy full SHA for c9494f6 - Browse repository at this point
Copy the full SHA c9494f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c99f41 - Browse repository at this point
Copy the full SHA 2c99f41View commit details -
Configuration menu - View commit details
-
Copy full SHA for 00733ec - Browse repository at this point
Copy the full SHA 00733ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 95fd513 - Browse repository at this point
Copy the full SHA 95fd513View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a1b5e9 - Browse repository at this point
Copy the full SHA 6a1b5e9View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.