-
-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update check-error #1528
Update check-error #1528
Conversation
@koddsson I see a new release for As for chai itself, you need to alter how its loaded here: Line 148 in 1a8247f
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my previous comment
I don't know what branch this file is in, but I'm targetting the |
Right, I missed that part as it wasn't mentioned in the PR itself and neither any link to any milestone or such :) |
@keithamus; I don't have merge rights, so I can't land this myself. It also might be good to remove node12 and node14 as required builds in the repo settings, since they are never going to be reported. |
Since it's now an ES Module! :)