Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: accept empty keys when actual object is empty #1384

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: accept empty keys when actual object is empty #1384

wants to merge 1 commit into from
+33 −1

Commits on Apr 6, 2021

  1. fix: accept empty keys when actual object is empty 

    When comparing object keys, the user may happen upon comparing two empty
objects. Before this commit, this would be an error:

    // before
    expect({}).to.have.all.keys({});
    AssertionError: keys required

This commit makes it legal for `keys` to accept no keys when the actual object
is itself empty.
    @Zirak
    Zirak committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    e5585a2 View commit details
    Browse the repository at this point in the history