Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to run under Wayland #2178

Merged
merged 2 commits into from Sep 3, 2023

Conversation

illode
Copy link
Contributor

@illode illode commented Sep 1, 2023

Fixes #1527 by adding the chromium flags needed to run under Wayland.

Flags

Since chromium parses the flags regardless of chainner, preventing the arg parser from throwing an error is enough to make the flags work. Technically, this can be done in v0.19.4 already using chainner open '' --ozone-platform-hint=auto, but that's cumbersome and not obvious.

Ideally --ozone-platform-hint should be enabled by default, but I couldn't find a way to pass it to electron outside of the CLI. The arg parsing would probably have to be done in a wrapper that calls the real chainner binary for this to work.

References:

desktopName package.json field

On Wayland, if the .desktop file name doesn't match the app_id, the compositor won't be able to find .desktop file and thus can't find the icon. With the desktopName field unset, electron falls back to chaiNNer.desktop as the app_id, but the Linux makers all package the .desktop file as chainner.desktop. Since they don't match, the icon is missing. The desktopName field can be used to manually specify the app_id so everything works as expected.

Copy link
Member

@joeyballentine joeyballentine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll trust you that this works. Thanks!

@joeyballentine joeyballentine merged commit 1a7996d into chaiNNer-org:main Sep 3, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails to launch using Wayland on Linux
2 participants