Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node visibility #1624

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

theflyingzamboni
Copy link
Collaborator

@theflyingzamboni theflyingzamboni commented Mar 4, 2023

Introduces a toggle for an alternate selector pane mode that turns it into a node visibility settings menu. Nodes can be toggled off/on individually, by subcategory, or by category. All nodes will be visible when this mode is active, but switching back will hide any nodes/categories/subcategories that are not checked. This applies to the context selector pane as well. Newly added nodes should be visible by default.

Current issues:

  • I've set it so that the node single-click tooltip does not pop up in node visibility mode, as clicking the checkbox would cause this to trigger. However, if you click a node and then switch quickly back to normal mode, it will still pop up then.
  • There's a noticeable latency between clicking a checkbox and the checkbox changing state. This has occurred from the start even before cat and subcat hiding were implemented, and I'm not sure what the slowdown is. It works basically the same way as favoriting nodes, but seems less responsive.
  • General aesthetics. I didn't really put much into deciding how to position the checkboxes aside from the nodes themselves, where they replace the favorites icon.

Closes #1373

@theflyingzamboni theflyingzamboni marked this pull request as ready for review March 4, 2023 03:50
@RunDevelopment
Copy link
Member

Without having reviewed the code, a few thoughts and observations.

  1. Lag. Entering and leaving edit mode takes almost a second on my machine due to the extreme lag. 730ms to be exact. Making any change in edit mode (so hiding or unhiding any node, sub category, or category) also causes this lag.
    image
  2. The rounded corners of the button and the space to the left of it look weird.
    image
  3. The proximity of the toggle button to the search bar makes it seem like the toggle has something to do with it. Very confusing.
  4. When I collapse the Favorites category and enter edit mode, it then collapses the Image category. In general, when any category is collapsed, and you enter edit mode, the category after it will be collapsed.
  5. The arrow up is too close to the checkbox IMO
    image
  6. I don't like that checkboxes aren't aligned. Probably hard to change though.
    image
  7. Hiding a node hides them everywhere. You literally can't use them anymore (if they aren't included in your chain already). You can't even find them in the context selector pane. This means that hiding a node is a much more consequential change than just cleaning up the node selector panel. I honestly think it goes too far. I think my main issue is that you can't find these nodes even if you search them (text search).

@theflyingzamboni
Copy link
Collaborator Author

theflyingzamboni commented Mar 7, 2023

Thanks for reminding me of number 4. That was something I had meant to fix, but forgot about.

2 and 3: I kind of just threw the button here to get everything working. I'm not really sure where to place it, aside from on the line with the search bar.

As for 5 and 6, to be honest I don't know how to place the check marks. In a normal hierarchical check mark system, the checks would be on the left and indent by like a bulleted list. Since the check replaces the favorite icon, I put them on the right. But putting them over there leaves me unsure how to place them to indicate hierarchy. So the placement may need rethinking. I wanted people to try to use it before I got too fiddly with that, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide nodes
2 participants