Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type fixes for Pint >= 0.19.3 and attrs fixes for Python 3.11. #25

Merged
merged 6 commits into from Nov 2, 2022

Conversation

cgevans
Copy link
Owner

@cgevans cgevans commented Nov 1, 2022

@cgevans cgevans changed the title Typefixes and 311 Type fixes for Pint >= 0.19.3 and attrs fixes for Python 3.11. Nov 1, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2022

Codecov Report

Merging #25 (bf9d192) into main (07f28ed) will increase coverage by 0.74%.
The diff coverage is 95.83%.

@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
+ Coverage   73.16%   73.91%   +0.74%     
==========================================
  Files          14       14              
  Lines        1994     1997       +3     
==========================================
+ Hits         1459     1476      +17     
+ Misses        535      521      -14     
Impacted Files Coverage Δ
src/alhambra_mixes/mixes.py 66.84% <ø> (ø)
src/alhambra_mixes/actions.py 85.52% <50.00%> (ø)
src/alhambra_mixes/components.py 89.37% <100.00%> (ø)
src/alhambra_mixes/dictstructure.py 61.53% <100.00%> (ø)
src/alhambra_mixes/experiments.py 100.00% <100.00%> (ø)
src/alhambra_mixes/printing.py 60.58% <100.00%> (ø)
src/alhambra_mixes/quantitate.py 53.97% <100.00%> (ø)
src/alhambra_mixes/references.py 66.02% <100.00%> (ø)
src/alhambra_mixes/units.py 88.18% <100.00%> (+13.41%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dave-doty
Copy link
Collaborator

I actually can't find documentation for PlainQuantity in pint. What is it? Do you have a link to a description of it?

@dave-doty
Copy link
Collaborator

I actually can't find documentation for PlainQuantity in pint. What is it? Do you have a link to a description of it?

In general the pint API seems incomplete: https://pint.readthedocs.io/en/stable/api/specific.html

For instance, there's another module pint.testing, but I don't see it mentioned in the link above.

Is that site out of date and their real documentation is elsewhere?

@cgevans
Copy link
Owner Author

cgevans commented Nov 2, 2022

This is confusing overall. After discussion on the pint issue, I've mostly switched back to Quantity instead of PlainQuantity, except where it is actually needed for mypy to stop complaining. PlainQuantity appears to be a new addition that isn't supposed to usually be necessary, but in adding it, the generic for the magnitude type for Quantity was removed. I'm hoping that will be added back at some point.

@cgevans cgevans merged commit ad6d77d into main Nov 2, 2022
@cgevans cgevans deleted the typefixes-and-311 branch November 2, 2022 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants