Switch to pyproject.toml and add a tox -e interactive environment
#71
Conversation
willbarton
force-pushed
the
pyproject-toml
branch
from
aaa6bdc
to
2a6c72f
Compare
willbarton
force-pushed
the
pyproject-toml
branch
from
2a6c72f
to
038a6b9
Compare
|
You'll never guess where I copied these files from. |
With [PEP 621 support added to setuptools](pypa/setuptools#2970) last year, and with pip supporting editable installs as of 21.3, we can move to `pyproject.toml` and deprecate `setup.py`. The file remains for legacy pip support. Because [flake8 does not want to support pyproject.tml yet](PyCQA/flake8#234), unlike all the other tools we use, I’m removing it in favor of [ruff](https://github.com/charliermarsh/ruff). Co-authored-by: Andy Chosak <andy.chosak@cfpb.gov>
This commit adds a new `tox -e interactive` that runs a local test server, to make it easier to test this project. This is a feature that [wagtail-localize](https://www.wagtail-localize.org/#how-to-run-tests) has that we’ve also added to [wagtail-inventory](https://github.com/cfpb/wagtail-inventory#testing) and [wagtail-treemodeladmin](https://github.com/cfpb/wagtail-treemodeladmin). 🎩 to @chosak for this pattern. Co-authored-by: Andy Chosak <andy.chosak@cfpb.gov>
willbarton
force-pushed
the
pyproject-toml
branch
from
d90de96
to
0814b0d
Compare
| - name: Install dependencies | ||
| run: | | ||
| python -m pip install --upgrade pip | ||
| python -m pip install --upgrade pip build | ||
| pip install twine wheel |
There was a problem hiding this comment.
| pip install twine wheel | |
| pip install twine |
Is wheel needed here? From using python -m build (very cool, by the way, TIL this is a thing), it looks like the build package handles that install itself in an isolated environment.
| @@ -1,6 +1,55 @@ | |||
| [project] | |||
| name = "wagtail-flags" | |||
| version = "5.3.0" | |||
There was a problem hiding this comment.
Might want to mention this version bump in the PR description -- although, are you still planning on releasing an interim 5.3.0, or just going to 6.x in #72?
| [build-system] | ||
| requires = ["setuptools>=43.0.0", "wheel"] | ||
| build-backend = "setuptools.build_meta" |
There was a problem hiding this comment.
How do these lines relate to the use of python -m build in the release GHA? Is this duplication? Or are these the lines that tell the build package to install wheel?
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v1 | ||
| - uses: actions/checkout@v2 |
There was a problem hiding this comment.
v3 is out. Can this use actions/checkout@v3? https://github.com/actions/checkout/releases/tag/v3.3.0
With PEP 621 support added to setuptools last year, and with pip supporting editable installs as of 21.3, we can move to
pyproject.tomland deprecatesetup.py. The file remains for legacy pip support.Because flake8 does not want to support pyproject.tml yet, unlike all the other tools we use, I’m removing it in favor of ruff.
This change also adds a new
tox -e interactivethat runs a local test server, to make it easier to test this project.This is a feature that wagtail-localize has that we’ve also added to wagtail-inventory and wagtail-treemodeladmin. 🎩 to @chosak for this pattern.